Conversation
Signed-off-by: Christian Glusa <caglusa@sandia.gov>
Signed-off-by: Christian Glusa <caglusa@sandia.gov>
Signed-off-by: Christian Glusa <caglusa@sandia.gov>
Signed-off-by: Christian Glusa <caglusa@sandia.gov>
Signed-off-by: Christian Glusa <caglusa@sandia.gov>
Signed-off-by: Christian Glusa <caglusa@sandia.gov>
Signed-off-by: Christian Glusa <caglusa@sandia.gov>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors ASSERT_DEFINED calls across numerous CMakeLists.txt files to assert variables individually rather than passing multiple arguments to a single call. This pattern is applied throughout various packages such as MueLu, Stokhos, and Thyra. Feedback indicates that in packages/nox/test/epetra/Thyra/CMakeLists.txt, some calls still contain multiple variables, which should be split into individual assertions to ensure all variables are properly checked.
| ASSERT_DEFINED(NOX_ENABLE_Epetra NOX_ENABLE_EpetraExt) | ||
| ASSERT_DEFINED(NOX_ENABLE_Stratimikos Stratimikos_ENABLE_AztecOO) |
There was a problem hiding this comment.
The pull request description states that ASSERT_DEFINED only asserts the first variable. However, these lines still contain multiple arguments, meaning NOX_ENABLE_EpetraExt and Stratimikos_ENABLE_AztecOO will not be checked. These should be split into individual calls to ensure all variables are properly asserted.
ASSERT_DEFINED(NOX_ENABLE_Epetra)
ASSERT_DEFINED(NOX_ENABLE_EpetraExt)
ASSERT_DEFINED(NOX_ENABLE_Stratimikos)
ASSERT_DEFINED(Stratimikos_ENABLE_AztecOO)
|
CDash for AT1 results [Only accessible from Sandia networks] |
2 participants
Automated mirror of upstream PR trilinos#15114 ## Motivation
It looks like
assert_definedonly asserts that the first variable is defined..